Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreiface: add a testing.T argument to the provider #321

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented May 30, 2023

No description provided.

@Jorropo Jorropo requested a review from a team as a code owner May 30, 2023 17:09
This is usefull because it allows the Provider to use t.Cleanup for cleaning up the nodes.
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@Jorropo Jorropo enabled auto-merge (rebase) May 30, 2023 17:10
@Jorropo Jorropo disabled auto-merge May 30, 2023 17:11
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #321 (5f18224) into main (0cfdf85) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   49.36%   49.32%   -0.04%     
==========================================
  Files         281      281              
  Lines       33708    33708              
==========================================
- Hits        16639    16627      -12     
- Misses      15330    15341      +11     
- Partials     1739     1740       +1     
Impacted Files Coverage Δ
coreiface/tests/api.go 0.00% <0.00%> (ø)
coreiface/tests/block.go 0.00% <0.00%> (ø)
coreiface/tests/dag.go 0.00% <0.00%> (ø)
coreiface/tests/dht.go 0.00% <0.00%> (ø)
coreiface/tests/key.go 0.00% <0.00%> (ø)
coreiface/tests/name.go 0.00% <0.00%> (ø)
coreiface/tests/object.go 0.00% <0.00%> (ø)
coreiface/tests/path.go 0.00% <0.00%> (ø)
coreiface/tests/pin.go 0.00% <0.00%> (ø)
coreiface/tests/pubsub.go 0.00% <0.00%> (ø)
... and 2 more

... and 11 files with indirect coverage changes

@Jorropo Jorropo merged commit c23df38 into main May 30, 2023
@Jorropo Jorropo deleted the coreiface branch May 30, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants