Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not rely on deprecated logger #338

Merged
merged 1 commit into from
Jun 7, 2023
Merged

chore: do not rely on deprecated logger #338

merged 1 commit into from
Jun 7, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jun 7, 2023

Replace go-log by go-log/v2 everywhere.

@hacdias hacdias self-assigned this Jun 7, 2023
@hacdias hacdias requested review from lidel and a team as code owners June 7, 2023 11:12
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #338 (37dc7e9) into main (0927be4) will increase coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   49.26%   49.56%   +0.30%     
==========================================
  Files         280      283       +3     
  Lines       33850    33865      +15     
==========================================
+ Hits        16675    16786     +111     
+ Misses      15398    15315      -83     
+ Partials     1777     1764      -13     
Impacted Files Coverage Δ
bitswap/bitswap.go 37.20% <ø> (ø)
bitswap/client/client.go 82.21% <ø> (ø)
bitswap/client/internal/getter/getter.go 64.10% <ø> (ø)
...tswap/client/internal/messagequeue/messagequeue.go 67.32% <ø> (+2.77%) ⬆️
bitswap/client/internal/peermanager/peermanager.go 65.41% <ø> (ø)
...ernal/providerquerymanager/providerquerymanager.go 64.73% <ø> (ø)
bitswap/client/internal/session/session.go 82.18% <ø> (ø)
.../internal/sessionpeermanager/sessionpeermanager.go 72.50% <ø> (ø)
bitswap/network/ipfs_impl.go 0.00% <ø> (ø)
bitswap/server/internal/decision/engine.go 76.05% <ø> (ø)
... and 17 more

... and 12 files with indirect coverage changes

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk what the implications are but the actual code changes make sense.

@hacdias hacdias merged commit 2185f40 into main Jun 7, 2023
@hacdias hacdias deleted the fix/logger branch June 7, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants