Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: run gofumpt #441

Merged
merged 2 commits into from
Aug 21, 2023
Merged

style: run gofumpt #441

merged 2 commits into from
Aug 21, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 21, 2023

#439 but not using my fork this time

@Jorropo Jorropo requested review from lidel, hacdias and a team as code owners August 21, 2023 08:02
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #441 (812b17c) into main (aa73ad5) will decrease coverage by 0.03%.
The diff coverage is 60.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   50.10%   50.08%   -0.03%     
==========================================
  Files         249      249              
  Lines       30017    29998      -19     
==========================================
- Hits        15039    15023      -16     
+ Misses      13545    13540       -5     
- Partials     1433     1435       +2     
Files Changed Coverage Δ
bitswap/bitswap.go 37.20% <ø> (ø)
...wap/client/internal/notifications/notifications.go 72.94% <ø> (-0.32%) ⬇️
bitswap/internal/testutil/testutil.go 33.33% <ø> (ø)
bitswap/message/pb/message.pb.go 29.73% <ø> (ø)
bitswap/network/ipfs_impl.go 0.00% <0.00%> (ø)
bitswap/server/internal/decision/engine.go 76.05% <ø> (ø)
bitswap/server/server.go 51.76% <ø> (+0.15%) ⬆️
blockstore/blockstore.go 57.97% <ø> (-0.31%) ⬇️
blockstore/bloom_cache.go 57.14% <ø> (ø)
blockstore/idstore.go 62.66% <ø> (ø)
... and 72 more

... and 4 files with indirect coverage changes

@Jorropo Jorropo force-pushed the gofumpt-for-real-this-time branch from a790e66 to bad387c Compare August 21, 2023 08:09
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting to see how inconsistent our code is regarding empty lines.

Commented out just clutters everything, we have the git history if needed.
@Jorropo Jorropo force-pushed the gofumpt-for-real-this-time branch from bad387c to 812b17c Compare August 21, 2023 08:09
@Jorropo Jorropo enabled auto-merge (rebase) August 21, 2023 08:10
@Jorropo Jorropo merged commit 2668886 into main Aug 21, 2023
@Jorropo Jorropo deleted the gofumpt-for-real-this-time branch August 21, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants