Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert peer exclude cancel #809

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Revert peer exclude cancel #809

merged 3 commits into from
Jan 23, 2025

Conversation

gammazero
Copy link
Contributor

This reverts both PR #805 and #784.

Reverting the fix attempt to prevent sending cancels to a peers that sent blocks. Logic needs to be implemented that has to go all the way to modifying any already queued outgoing messages to that peer, as that message may contain other things that are not being canceled.

This issue can be addressed in a future rework of bitswap.

@gammazero gammazero requested a review from a team as a code owner January 22, 2025 23:11
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.52%. Comparing base (13fd890) to head (6f65ed7).
Report is 4 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
+ Coverage   60.46%   60.52%   +0.05%     
==========================================
  Files         244      244              
  Lines       31106    31101       -5     
==========================================
+ Hits        18809    18824      +15     
+ Misses      10621    10599      -22     
- Partials     1676     1678       +2     
Files with missing lines Coverage Δ
bitswap/client/internal/peermanager/peermanager.go 91.85% <100.00%> (ø)
...wap/client/internal/peermanager/peerwantmanager.go 88.50% <100.00%> (-0.20%) ⬇️
bitswap/client/internal/session/session.go 90.56% <ø> (+0.75%) ⬆️
...p/client/internal/sessionmanager/sessionmanager.go 95.78% <100.00%> (-4.22%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this, It seems that reverting to version from boxo v0.26.0 is the right play for now.

If things look on on staging, feel free to release boxo patch.
We will include this in Kubo 0.33.0-rc3.

@gammazero gammazero merged commit 3e3de8f into main Jan 23, 2025
15 checks passed
@gammazero gammazero deleted the revert-peer-exclude-cancel branch January 23, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants