Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"All commits should pass" in contribution guidelines #22

Closed
dylanPowers opened this issue May 20, 2015 · 0 comments
Closed

"All commits should pass" in contribution guidelines #22

dylanPowers opened this issue May 20, 2015 · 0 comments
Assignees
@dylanPowers

Comments

@dylanPowers
Copy link
Member

There needs to be a section in the contribution guidelines that describes how we have the hard constraint that all commits should pass, so that git bisect is very easy to run.

Brought up in ipfs/kubo#1239 (comment)
@dylanPowers dylanPowers self-assigned this May 20, 2015
@whyrusleeping whyrusleeping mentioned this issue Jun 9, 2015
Closed
50 tasks
dylanPowers added a commit to dylanPowers/ipfs-community that referenced this issue Jun 13, 2015
@dylanPowers
All commits must pass
6cd6b09 
Fixes ipfs#22
@dylanPowers dylanPowers mentioned this issue Jun 13, 2015
Merged
@dylanPowers dylanPowers added status/in-progress In progress and removed sprint labels Jun 13, 2015
@jbenet jbenet removed the status/in-progress In progress label Jun 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylanPowers dylanPowers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbenet @dylanPowers