-
Notifications
You must be signed in to change notification settings - Fork 55
Add base64 favicon and social sharing meta tags #36
Conversation
Thanks to @lidel for raising the idea of an inline favicon! Sending to both @Stebalien and @aschmahmann for review, since I'm not sure whose purview this falls under these days. |
@aschmahmann is big boss now. |
Proof of display for social sharing cards ... note that these are all using https://gateway.ipfs.io/ipfs/QmUj1ZWPLTvzZhzUFqmthsCwWm6Tn8rF5cyV9h8xCSKVQ2 as a test, which is simply a view-source of my local instance of this branch saved as regular HTML. Twitter (via https://cards-dev.twitter.com/validator): Facebook (via https://developers.facebook.com/tools/debug/): |
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
@lidel had a great idea to dynamically insert title element for cases in which someone might be social-previewing multiple links. Amended, and new previews follow using https://gateway.ipfs.io/ipfs/QmNjia5FrrhnrUgtKmzFKvbkJNvAL2Rmc9xxYiVw5GA3xs (again, saved-as regular HTML from my local) ... Twitter (via https://cards-dev.twitter.com/validator): Facebook (via https://developers.facebook.com/tools/debug/): @lidel -- you'll see in the Facebook preview that something as long as a CID in that dynamic title field pushes the subtitle out of the available space. I'd actually lean toward restoring the original Facebook meta tags to result in the earlier screenshot -- I know that's not dynamic, and doesn't help differentiate if someone posts a bunch of links to FB, but at least the generic one has some meaning. LMK. @aschmahmann -- in any case, I think we're close enough to done for you to be able to review this 😊 |
@lidel OR -- this is actually preferable -- let's just reverse the title and description tags for Facebook (and others who use the Using https://gateway.ipfs.io/ipfs/QmXFhdYS5EwEVp3Ri2jARj9bmmzT1doZk5CzqVrJX2LRsp ... Slack reverses the order from my previous comment's screenshot, since it uses the same meta tags as FB: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Feel free to merge after @lidel approves.
@lidel -- we chatted briefly about this but just want to confirm you're OK with this as it stands. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ship it! 👍
(we can always revisit Open Graph / Twitter tags in the future)
FYI -- this one is PR'd into go-ipfs as ipfs/kubo#7511 |
Small enhancements to dir-index-html pages: