Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ESLint Rules #131

Closed
wants to merge 3 commits into from
Closed

fix: ESLint Rules #131

wants to merge 3 commits into from

Conversation

whizzzkid
Copy link

@whizzzkid whizzzkid requested a review from achingbrain February 5, 2023 21:00
@whizzzkid whizzzkid changed the title feat!: ESLint Rules fix: ESLint Rules Feb 5, 2023
achingbrain
achingbrain requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please split this into three separate PRs, one for each rule. Any tightening of the linting rules is a breaking change and worth discussing.

@achingbrain
Copy link
Member

Closing pending PRs that break each change out.

@achingbrain achingbrain closed this Apr 5, 2023
@achingbrain achingbrain deleted the fix/eslint-rules branch April 5, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change @typescript-eslint/return-await to in-try-catch?
2 participants
@whizzzkid @achingbrain