Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect upper-case hex digits in escaped redirect URL #225

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented Jan 2, 2025

This is needed for ipfs/boxo#779.

Regardless of boxo changes it seems more correct to expect upper-case hex for percent-escaped characters:

RFC3986 §2.1

For consistency, URI producers and normalizers should use uppercase hexadecimal digits for all percent-encodings.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1308 6 0 0

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1308 6 0 0

@gammazero gammazero changed the title Handle boxo changes to redirect URL Expect upper-case hex digits in escaped redirect URL Jan 2, 2025
@gammazero gammazero merged commit 4bb55f3 into main Jan 3, 2025
11 checks passed
@gammazero gammazero deleted the updated-redirect-urls branch January 3, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant