Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update v0.11.0 #106

Merged
merged 1 commit into from
Jun 9, 2023
Merged

chore: update v0.11.0 #106

merged 1 commit into from
Jun 9, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jun 9, 2023

This should solves this issue when trying to build with boxo v0.9.0.

make       
go generate
go build -tags netgo -ldflags="-s -w -X main.Commit=3b0eb73 -X main.Version=v1.0.2-53-g3b0eb73-dirty" -o edge
# github.com/ipfs/go-merkledag
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:26:9: undefined: format.Register
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:27:9: undefined: format.Register
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:28:9: undefined: format.Register
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:30:9: undefined: ipldlegacy.RegisterCodec
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:31:9: undefined: ipldlegacy.RegisterCodec
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:86:16: undefined: ipldlegacy.DecodeNode
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:146:16: undefined: ipldlegacy.DecodeNode
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:254:23: undefined: ipldlegacy.DecodeNode
make: *** [build] Error 2

This should solves this issue when trying to build with `boxo v0.9.0`.
```console
❯ make       
go generate
go build -tags netgo -ldflags="-s -w -X main.Commit=3b0eb73 -X main.Version=v1.0.2-53-g3b0eb73-dirty" -o edge
# github.com/ipfs/go-merkledag
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:26:9: undefined: format.Register
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:27:9: undefined: format.Register
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:28:9: undefined: format.Register
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:30:9: undefined: ipldlegacy.RegisterCodec
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:31:9: undefined: ipldlegacy.RegisterCodec
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:86:16: undefined: ipldlegacy.DecodeNode
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:146:16: undefined: ipldlegacy.DecodeNode
../../../go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:254:23: undefined: ipldlegacy.DecodeNode
make: *** [build] Error 2
```
@Jorropo Jorropo requested a review from willscott June 9, 2023 16:07
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Suggested version: v0.11.0

Comparing to: v0.10.0 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index 4b3ca8f..06b055e 100644
--- a/go.mod
+++ b/go.mod
@@ -11,9 +11,8 @@ require (
 	github.com/ipfs/go-ipfs-blockstore v1.2.0
 	github.com/ipfs/go-ipfs-exchange-offline v0.3.0
 	github.com/ipfs/go-ipfs-util v0.0.2
-	github.com/ipfs/go-ipld-cbor v0.0.6
-	github.com/ipfs/go-ipld-format v0.4.0
-	github.com/ipfs/go-ipld-legacy v0.1.1
+	github.com/ipfs/go-ipld-format v0.5.0
+	github.com/ipfs/go-ipld-legacy v0.2.1
 	github.com/ipfs/go-log/v2 v2.5.1
 	github.com/ipld/go-codec-dagpb v1.6.0
 	github.com/ipld/go-ipld-prime v0.20.0
@@ -28,6 +27,7 @@ require (
 	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/google/gopacket v1.1.19 // indirect
 	github.com/google/uuid v1.3.0 // indirect
+	github.com/gopherjs/gopherjs v0.0.0-20181017120253-0766667cb4d1 // indirect
 	github.com/hashicorp/golang-lru v0.5.4 // indirect
 	github.com/huin/goupnp v1.0.3 // indirect
 	github.com/ipfs/bbloom v0.0.4 // indirect
@@ -43,6 +43,7 @@ require (
 	github.com/ipfs/go-verifcid v0.0.1 // indirect
 	github.com/jackpal/go-nat-pmp v1.0.2 // indirect
 	github.com/jbenet/goprocess v0.1.4 // indirect
+	github.com/jtolds/gls v4.2.1+incompatible // indirect
 	github.com/klauspost/cpuid/v2 v2.1.0 // indirect
 	github.com/koron/go-ssdp v0.0.3 // indirect
 	github.com/libp2p/go-buffer-pool v0.1.0 // indirect
@@ -71,9 +72,9 @@ require (
 	github.com/multiformats/go-varint v0.0.6 // indirect
 	github.com/opentracing/opentracing-go v1.2.0 // indirect
 	github.com/polydawn/refmt v0.0.0-20201211092308-30ac6d18308e // indirect
+	github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d // indirect
 	github.com/spacemonkeygo/spacelog v0.0.0-20180420211403-2296661a0572 // indirect
 	github.com/spaolacci/murmur3 v1.1.0 // indirect
-	github.com/whyrusleeping/cbor-gen v0.0.0-20200123233031-1cdf64d27158 // indirect
 	go.opentelemetry.io/otel v1.7.0 // indirect
 	go.opentelemetry.io/otel/trace v1.7.0 // indirect
 	go.uber.org/atomic v1.10.0 // indirect
@@ -81,11 +82,10 @@ require (
 	go.uber.org/zap v1.22.0 // indirect
 	golang.org/x/crypto v0.0.0-20220525230936-793ad666bf5e // indirect
 	golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4 // indirect
-	golang.org/x/net v0.0.0-20220812174116-3211cb980234 // indirect
+	golang.org/x/net v0.7.0 // indirect
 	golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4 // indirect
-	golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab // indirect
+	golang.org/x/sys v0.5.0 // indirect
 	golang.org/x/tools v0.1.12 // indirect
-	golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
 	google.golang.org/protobuf v1.28.1 // indirect
 	lukechampine.com/blake3 v1.1.7 // indirect
 )

gorelease says:

# github.com/ipfs/go-merkledag
## errors in release version:
/home/runner/go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:26:9: undefined: format.Register
/home/runner/go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:27:9: undefined: format.Register
/home/runner/go/pkg/mod/github.com/ipfs/[email protected]/merkledag.go:28:9: undefined: format.Register

# diagnostics
go.mod: the following requirements are needed
	github.com/jtolds/[email protected]+incompatible
	github.com/ipfs/[email protected]
	github.com/ipfs/[email protected]
	github.com/whyrusleeping/[email protected]
	golang.org/x/[email protected]
Run 'go mod tidy' to add missing requirements.

# summary
Cannot suggest a release version.
Errors were found.

gocompat says:

Your branch is up to date with 'origin/master'.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@willscott willscott merged commit 890b4a2 into master Jun 9, 2023
@Jorropo Jorropo deleted the Jorropo-patch-1 branch June 9, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants