fix: add pointer receiver

ipfs · May 6, 2021 · cd9b8c9 · cd9b8c9
1 parent 930e8c9
commit cd9b8c9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/io/directory.go b/io/directory.go
@@ -100,7 +100,7 @@ func NewDirectory(dserv ipld.DAGService) Directory {
 	basicDir := new(BasicDirectory)
 	basicDir.node = format.EmptyDirNode()
 	basicDir.dserv = dserv
-	return UpgradeableDirectory{basicDir}
+	return &UpgradeableDirectory{basicDir}
 }
 
 // ErrNotADir implies that the given node was not a unixfs directory
@@ -308,7 +308,7 @@ var _ Directory = (*UpgradeableDirectory)(nil)
 
 // AddChild implements the `Directory` interface. We check when adding new entries
 // if we should switch to HAMTDirectory according to global option(s).
-func (d UpgradeableDirectory) AddChild(ctx context.Context, name string, nd ipld.Node) error {
+func (d *UpgradeableDirectory) AddChild(ctx context.Context, name string, nd ipld.Node) error {
 	if UseHAMTSharding {
 		if basicDir, ok := d.Directory.(*BasicDirectory); ok {
 			hamtDir, err := basicDir.SwitchToSharding(ctx)

diff --git a/io/directory_test.go b/io/directory_test.go
@@ -105,7 +105,7 @@ func TestUpgradeableDirectory(t *testing.T) {
 	ds := mdtest.Mock()
 	UseHAMTSharding = false // Create a BasicDirectory.
 	dir := NewDirectory(ds)
-	if _, ok := dir.(UpgradeableDirectory).Directory.(*BasicDirectory); !ok {
+	if _, ok := dir.(*UpgradeableDirectory).Directory.(*BasicDirectory); !ok {
 		t.Fatal("UpgradeableDirectory doesn't contain BasicDirectory")
 	}
 
@@ -117,7 +117,7 @@ func TestUpgradeableDirectory(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	if _, ok := dir.(UpgradeableDirectory).Directory.(*HAMTDirectory); !ok {
+	if _, ok := dir.(*UpgradeableDirectory).Directory.(*HAMTDirectory); !ok {
 		t.Fatal("UpgradeableDirectory wasn't upgraded to HAMTDirectory")
 	}
 }