Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add auto-tls support #716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add auto-tls support #716

wants to merge 1 commit into from

Conversation

achingbrain
Copy link
Member

Adds a WebSocket listener to libp2p and configures auto-tls to automatically upgrade it to a secure WebSocket

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
feat: add auto-tls support
243c45d 
Adds a WebSocket listener to libp2p and configures auto-tls to
automatically upgrade it to a secure WebSocket
@achingbrain achingbrain requested a review from a team as a code owner January 9, 2025 12:20
2color
2color approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@2color 2color left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@SgtPooki
Copy link
Member

SgtPooki commented Jan 9, 2025

FYI failing in CI for offline test with "keychain not set"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2color 2color 2color approved these changes

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achingbrain @SgtPooki @2color