Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS-Companion shows offline, but I have IPFS-Desktop working #1068

Closed
chadlupkes opened this issue Mar 20, 2022 · 2 comments · Fixed by ipfs/ipfs-desktop#2054
Closed

IPFS-Companion shows offline, but I have IPFS-Desktop working #1068

chadlupkes opened this issue Mar 20, 2022 · 2 comments · Fixed by ipfs/ipfs-desktop#2054
Assignees
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@chadlupkes
Copy link

Describe the bug
IPFS-Companion is offline, no matter what I do. I have tried restarting IPFS-Desktop, updating all software, etc.

Expected behavior
It was working perfectly until the last update.

Screenshots
If applicable, add screenshots to help explain your problem.
image
image
image

Desktop (please complete the following information):

Additional context
Add any other context about the problem here.

@chadlupkes chadlupkes added the need/triage Needs initial labeling and prioritization label Mar 20, 2022
@ipfs ipfs deleted a comment from welcome bot Mar 21, 2022
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Mar 21, 2022
@lidel
Copy link
Member

lidel commented Mar 21, 2022

Thank you for reporting this.

This is a regression introduced by ipfs/ipfs-desktop#1956 – it clashed with a bug in go-ipfs where localhost rpc api origin was safelisted only when no custom safelist was present. That PR added custom safelist, effectively disabling access to rpc api.

We fixed it in go-ipfs in ipfs/kubo#8690 by always safelisting 127.0.0.1:<port> (where port is RPC API at 5001) but go-ipfs 0.13 is not released yet.

I'll prepare a bugfix release of ipfs-desktop shortly (it will manually add 127.0.0.1:5001 for now)

@lidel lidel added P0 Critical: Tackled by core team ASAP and removed need/triage Needs initial labeling and prioritization labels Mar 21, 2022
@lidel lidel self-assigned this Mar 21, 2022
lidel added a commit to ipfs/ipfs-desktop that referenced this issue Mar 21, 2022
lidel added a commit to ipfs/ipfs-desktop that referenced this issue Mar 21, 2022
@chadlupkes
Copy link
Author

Fixed, works perfectly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants