Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not redirect http://0.0.0.0:5001/webui #867

Closed
lidel opened this issue Apr 17, 2020 · 0 comments · Fixed by #868
Closed

Do not redirect http://0.0.0.0:5001/webui #867

lidel opened this issue Apr 17, 2020 · 0 comments · Fixed by #868
Assignees
@lidel
Labels
area/firefox Issues related to Mozilla Firefox effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/in-progress In progress

Comments

@lidel
Copy link
Member

lidel commented Apr 17, 2020 •
edited
Loading

When go-ipfs starts in Docker it prints http://0.0.0.0:5001/webui to the console.

Opening http://0.0.0.0:5001/webui ends up on gateway port, and API access is broken due to CORS 🤦‍♂️

0.0.0.0 should not be redirected, should be ignored just like 127.0.0.1:5001
@lidel lidel added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked area/firefox Issues related to Mozilla Firefox effort/hours Estimated to take one or several hours labels Apr 17, 2020
@lidel lidel self-assigned this Apr 17, 2020
@lidel lidel added status/in-progress In progress and removed status/ready Ready to be worked labels Apr 18, 2020
lidel added a commit that referenced this issue Apr 18, 2020
@lidel
fix: normalize API calls from 0.0.0.0 to 127.0.0.1
adc3db8 
Closes #867
@lidel lidel mentioned this issue Apr 18, 2020
Merged
lidel added a commit that referenced this issue Apr 24, 2020
@lidel
fix: normalize API calls from 0.0.0.0 to 127.0.0.1 (#868)
793bd6c 
Closes #867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
area/firefox Issues related to Mozilla Firefox effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: normalize API calls from 0.0.0.0 to 127.0.0.1 ipfs/ipfs-companion
1 participant
@lidel