fix(ci): windows build #1094
Merged
fix(ci): windows build #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whizzzkid it is running in https://github.com/ipfs/ipfs-companion/runs/8139100657?check_suite_focus=true but takes longer than expected, when it timeouts you may want to inspect logs. |
whizzzkid
commented
Sep 1, 2022
|
@lidel looks like the build is stuck https://github.com/ipfs/ipfs-companion/runs/8139100657?check_suite_focus=true Turns out this is an issue: felixrieseberg/windows-build-tools#208 I added the suggested fix in the thread, sorry I couldn't test it locally without a windows machine. But that didn't kill the existing build. |
|
@lidel @SgtPooki I just realized I can run GH Actions on my own fork as well. so now this passes: https://github.com/whizzzkid/ipfs-companion/runs/8143445527?check_suite_focus=true Apologies for all the noise! |
whizzzkid
added a commit
to whizzzkid/ipfs-companion
that referenced
this pull request
Sep 11, 2022
* main: fix(ci): windows build (ipfs#1094)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like builds are broken on
windows-latest: https://github.com/ipfs/ipfs-companion/actions/workflows/ci.ymlThe reported error:
gyp ERR! stack Error: Could not find any Visual Studio installation to useI could not test this as I don't have perms to run CI nor do I have access to a windows machine atm, but there seems like two ways to fix this:
the github
actions/setup-node@v1is also 2 major versions behind, so should be upgraded as well, but I'm unsure of the breaking API changes between the two.🤞🏽 this should fix the broken builds in theory.