style: rename menu items for copying and sharing #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would “Copy IPFS content path” be more explicit? There’s room for it. |
|
@jessicaschilling yes, it believe its better to be explicit that its "IPFS thing". Updated – looks like this |
lidel
force-pushed
the
style/rename-sharing-link
branch
from
da32075 to
8a11845
Compare
|
Nice! Oh: “Resource” in the pinning menu item should be lowercase for consistency. Otherwise LGTM 😊 |
jessicaschilling
approved these changes
Apr 5, 2020
lidel
force-pushed
the
style/rename-sharing-link
branch
from
8a11845 to
4588310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #857
Copy Public Gateway URL→Copy shareable linkCopy IPFS Path→Copy IPFS content path