Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Mac) Force Files screen refresh when clicking on drag/drop success notification #1763

Closed
jessicaschilling opened this issue Feb 19, 2021 · 0 comments · Fixed by #1767
Closed

(Mac) Force Files screen refresh when clicking on drag/drop success notification #1763

jessicaschilling opened this issue Feb 19, 2021 · 0 comments · Fixed by #1767
Assignees
@lidel
Labels
area/macos MacOS effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked

Comments

@jessicaschilling
Copy link
Contributor

Note: Only tested on Mac, so not sure about impact on other OSes.

To reproduce problem:

  • Drag/drop multiple items onto the MacOS menubar icon
  • Wait until the "click here to view your files" notification pops up
  • Click it and get sent to the Files screen, which doesn't yet reflect the existence of the new files even though they're there. Refreshing or clicking away/back from Files screen shows the files

To fix:

  • Force page reload of Files screen upon clicking notification

Note:

  • Not sure if there's any consideration that needs to be made for single-file drag/drop -- these currently work fine, because clicking the notification takes you directly to the file, not the whole Files screen.
@jessicaschilling jessicaschilling added the need/triage Needs initial labeling and prioritization label Feb 19, 2021
@jessicaschilling jessicaschilling added area/macos MacOS exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Feb 19, 2021
@lidel lidel added good first issue Good issue for new contributors help wanted Seeking public contribution on this issue labels Feb 23, 2021
lidel added a commit that referenced this issue Feb 23, 2021
@lidel
fix(mac): refresh file list after import
30f953c 
Closes #1763

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel lidel mentioned this issue Feb 23, 2021
Merged
1 task
lidel added a commit that referenced this issue Feb 23, 2021
@lidel
fix(mac): refresh file list after import (#1767)
4c5c02d 
Closes #1763
@MarcelRaschke MarcelRaschke mentioned this issue Sep 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
area/macos MacOS effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mac): force-refresh file list after import ipfs/ipfs-desktop
2 participants
@lidel @jessicaschilling