Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak title of npm on ipfs preference #1742

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Tweak title of npm on ipfs preference #1742

merged 2 commits into from
Jan 25, 2021

Conversation

andrew
Copy link
Contributor

@andrew andrew commented Jan 22, 2021

As requested by @jessicaschilling in #1739 (comment)

Screenshot 2021-01-22 at 13 50 36

@andrew andrew mentioned this pull request Jan 22, 2021
Merged
jessicaschilling
jessicaschilling approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll defer to @lidel for OK/merging 😊

lidel
lidel requested changes Jan 22, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a toggle checkbox which installs/uninstalls, and other Experiments start with Enable, can we do the same? 🤔

assets/locales/en.json Outdated Show resolved Hide resolved
@lidel lidel merged commit cc4144f into ipfs:master Jan 25, 2021
@andrew andrew deleted the install-npm-on-ipfs branch January 25, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicaschilling jessicaschilling jessicaschilling approved these changes

@lidel lidel lidel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew @lidel @jessicaschilling