Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping multiple files only adds one on Chrome #1045

Closed
olizilla opened this issue May 24, 2019 · 4 comments · Fixed by #1049
Closed

Dropping multiple files only adds one on Chrome #1045

olizilla opened this issue May 24, 2019 · 4 comments · Fixed by #1049

Comments

@olizilla
Copy link
Member

Describe the bug
Using go-ipfs 0.4.19 & Chrome stable 74 drop multiple individual files... only 1 file is added.

To Reproduce
Steps to reproduce the behavior:

  1. Go to files
  2. Drop two or more files on the page
  3. Only one file appears added

Firefox is not affected. The files are all added as expected.

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome (and electron)
  • Version: 74
@olizilla
Copy link
Member Author

@hacdias we really need that test suite for adding files!

@hacdias
Copy link
Member

hacdias commented May 24, 2019

@olizilla I'll start working on them as soon as I can. I'll use the #1034 PR because it's related.

@olizilla
Copy link
Member Author

@hacdias let's keep the test suite seperate from work that changes how files get added. Please make a new branch off master for the suite, and then when we're happy with it, merge it in, and pull it into those branches. Step 1 is add file tests for webui.

@hacdias
Copy link
Member

hacdias commented May 27, 2019

Only one files get detected. Here's the issue for that: anatol-grabowski/datatransfer-files-promise#1

It seems that person found the fix, but the creator just closed the issue and didn't fix it.

olizilla pushed a commit that referenced this issue May 30, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes #1045 by using my [fork](https://github.com/hacdias/datatransfer-files-promise) of `datatransfer-files-promise`


License: MIT
Signed-off-by: Henrique Dias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants