chore: use [email protected] #2257
Conversation
SgtPooki
commented
Sep 6, 2024
SgtPooki
commented
- chore: update ipld-explorer-components
- chore: use [email protected]
| @@ -119,19 +138,20 @@ test.describe('Explore screen', () => { | |||
| }) | |||
|
|
|||
| test('should open dag-pb', async ({ page }) => { | |||
| test.setTimeout(60000) | |||
There was a problem hiding this comment.
I think the update of kubo-rpc-client, ipfsd-ctl, and @helia/http and underlying libraries caused some regression in fetch speed.. This is all being fetched locally but it's consistently very slow
There was a problem hiding this comment.
hm.. probably shot in the dark, but iirc in IPLD explorer if local gateway is not available, we fallback to public one, so perhaps the slowness is because local gateway cant be used, and tests pass only on slow fallback?
…ablish-libp2p-webtransport-connections
|
@lidel i've got CI passing now and code is at a good point. Can you take a peek? |
|
after this is merged, we will be at a good place to start removing |
There was a problem hiding this comment.
@SgtPooki I seem to consistently have one test failing locally, is it passing for you? If its just me (I have a old slow PC on purpose) maybe we need to increase timeout? or I need to purge something?
1) settings.test.js:77:3 › Settings screen › Submit/Reset Public Subdomain Gateway ───────────────
Test timeout of 30000ms exceeded.
Error: elementHandle.click: Target closed
=========================== logs ===========================
attempting click action
waiting for element to be visible, enabled and stable
element is not enabled - waiting...
============================================================
43 | // Check if the submit button is not null, and click it only if it's available
44 | if (submitButton) {
> 45 | await submitButton.click()
| ^
46 | }
47 | const hasExpectedClass = await checkClassWithTimeout(page, inputElement, expectedClass)
48 | expect(hasExpectedClass).toBe(true)
at submitGatewayAndCheck (/home/lidel/project/ipfs-webui/test/e2e/settings.test.js:45:24)
at /home/lidel/project/ipfs-webui/test/e2e/settings.test.js:87:5
Pending operations:
- elementHandle.click at test/e2e/settings.test.js:45:24
1 failed
settings.test.js:77:3 › Settings screen › Submit/Reset Public Subdomain Gateway ────────────────
37 passed (55.4s)
Some tests were failing for me locally as well (remote rpc api usually).. but I got an intermittent failure for that settings page locally as well |
|
Maybe we just were lucky on CI? I've re-run the same commit just to me sure. |
|
i've got a fix for the remote RPC one that fixes them locally. |
|
The job you kicked off succeeded, and you can see that e2e tests succeeded in the two commits after that, even though CI failed in total because of lint failures:
and then the latest had passing e2e tests as well: https://github.com/ipfs/ipfs-webui/actions/runs/10839174283?pr=2257 |
There was a problem hiding this comment.
Ok, I've figured it out. Sorry for blocking this @SgtPooki, it looked like race condition, but was the fault of my local /etc/hosts where I blackholed bafkreib6wedzfupqy7qh44sie42ub4mvfwnfukmw6s2564flajwnt4cvc4.ipfs.dweb.link while testing #2255.
The E2E test that was failing appends / to dweb.link, which made it run a subdomain-support test against the gateway, and it was failing on my box due to DNS failure (unable to confirm the URL is a valid subdomain gateway):
Once I removed blackhole from /etc/hosts it started passing.
So no blocker, lgtm, thanks for being patient with me.
ps. Playwright tooling improved, the --ui mode is really nice, I did npm run test:e2e -- --ui --grep "Settings" to debug this.
|
No problem.
absolutely. I've been running |
SgtPooki
deleted the
2250-webui-spawning-helia-and-failing-to-establish-libp2p-webtransport-connections
branch
## [4.3.1](v4.3.0...v4.3.1) (2024-09-23) CID `bafybeideglc722hiwhsy4kiyl2fivf5lr6wozy2iuixtgzkvl3v4hasaty` --- ### Bug Fixes * **file-preview:** safeSubresourceGwUrl ([#2253](#2253)) ([bb861a3](bb861a3)), closes [/github.com//issues/2246#issuecomment-2322192398](https://github.com/ipfs//github.com/ipfs/ipfs-webui/issues/2246/issues/issuecomment-2322192398) * **files:** avoid duplicated fetch during preview ([#2254](#2254)) ([eefae25](eefae25)), closes [#2217](#2217) * **files:** prefer subdomain gw in copied share links ([#2255](#2255)) ([e8c4421](e8c4421)) ### Trivial Changes * .io → .tech ([b9f622d](b9f622d)) * browserslist@latest ([#2251](#2251)) ([809c55a](809c55a)) * Pull transifex translations ([#2258](#2258)) ([2250374](2250374)) * use [email protected] ([#2257](#2257)) ([99ba9ac](99ba9ac))
|
🎉 This PR is included in version 4.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
