-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use [email protected] #2257
Merged
SgtPooki
merged 16 commits into
main
from
2250-webui-spawning-helia-and-failing-to-establish-libp2p-webtransport-connections
Sep 13, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b877344
chore: update ipld-explorer-components
SgtPooki 8563776
chore: use [email protected]
SgtPooki f87ef9c
feat: use latest kubo, kubo-rpc-client, & ipfsd-ctl
SgtPooki 0a6f592
test: debugging tests
SgtPooki ba3e311
fix(ci): typecheck for kubo-rpc-client
lidel 1963f49
fix: update ipld-explorer-components and fix explore tests
SgtPooki ea3c1a2
chore: remove unused imports
SgtPooki 4817683
chore: some minor cleanup
SgtPooki 9037ab9
Merge branch 'main' into 2250-webui-spawning-helia-and-failing-to-est…
SgtPooki d992a5e
test: fix RPC e2e tests
SgtPooki ea92b03
chore: lint fix
SgtPooki a707d2d
chore: code cleanup and type fixes
SgtPooki 1bc8667
chore: remove unused var in test
SgtPooki e2875c8
test: fix remote rpc api tests
SgtPooki f9ce631
chore: PR comments
SgtPooki ed21af7
chore: lint fix
SgtPooki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the update of
kubo-rpc-client
,ipfsd-ctl
, and@helia/http
and underlying libraries caused some regression in fetch speed.. This is all being fetched locally but it's consistently very slowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm.. probably shot in the dark, but iirc in IPLD explorer if local gateway is not available, we fallback to public one, so perhaps the slowness is because local gateway cant be used, and tests pass only on slow fallback?