Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update In-App CORS instructions to match README #1525

Merged
merged 1 commit into from
Jun 22, 2020
Merged

chore: update In-App CORS instructions to match README #1525

merged 1 commit into from
Jun 22, 2020

Conversation

Evanito
Copy link
Contributor

@Evanito Evanito commented Jun 20, 2020

Currently, the "API Not Connected" Error does not give the complete list of origins that need to be added to the IPFS settings according to the README.

This PR brings the In-App CORS instructions up to par with the README.

Haven't tested.

@jessicaschilling
Copy link
Contributor

@rafaelramalho19, can you please have a look?

@rafaelramalho19
Copy link
Contributor

Tested it out and lgtm, thank you @Evanito

@rafaelramalho19 rafaelramalho19 changed the title [SMALL] Update In-App CORS instructions to match README chore: update In-App CORS instructions to match README Jun 22, 2020
@rafaelramalho19 rafaelramalho19 merged commit 4274697 into ipfs:master Jun 22, 2020
@Evanito
Copy link
Contributor Author

Evanito commented Jun 22, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants