Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self-ref files page link in "no files" screen #1531

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Remove self-ref files page link in "no files" screen #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/locales/en/files.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"welcomeInfo": {
"header": "Welcome to the IPFS Web UI",
"paragraph1": "<0><0>Check the status</0> of your node, its Peer ID and connection info, the network traffic and the number of connected peers.</0>",
"paragraph2": "<0>Easily <1>manage files</1> in your IPFS repo. You can drag and drop to add files, and you can move, rename, delete, share or download them.</0>",
"paragraph2": "<0>Easily manage files in your IPFS repo. Drag and drop here to add files, and you can move, rename, delete, share or download them.</0>",
"paragraph3": "<0>You can <1>explore IPLD data</1> that underpins how IPFS works.</0>",
"paragraph4": "<0>See all of your <1>connected peers</1>, geolocated by their IP address.</0>",
"paragraph5": "<0><0>Review the settings</0> for your IPFS node, and update them to better suit your needs.</0>",
Expand Down Expand Up @@ -120,7 +120,7 @@
"inspect": "Inspect"
},
"previousFolder": "Go back to previous folder",
"fileLabel": "Select {type} {name} with size: {size}",
"fileLabel": "Select {type} {name} with size: {size}",
"hashUnavailable": "hash unavailable",
"checkboxLabel": "View more options for {name}",
"pins": "Pins",
Expand Down
2 changes: 1 addition & 1 deletion public/locales/ko-KR/files.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"welcomeInfo": {
"header": "Welcome to the IPFS Web UI",
"paragraph1": "<0><0>Check the status</0> of your node, it's Peer ID and connection info, the network traffic and the number of connected peers.</0>",
"paragraph2": "<0>Easily <1>manage files</1> in your IPFS repo. You can drag and drop to add files, move and rename them, delete, share or download them.</0>",
"paragraph2": "<0>Easily manage files in your IPFS repo. Drag and drop here to add files, move and rename them, delete, share or download them.</0>",
"paragraph3": "<0>You can <1>explore IPLD data</1> that underpins how IPFS works.</0>",
"paragraph4": "<0>See all of your <1>connected peers</1>, geolocated by their IP address.</0>",
"paragraph5": "<0><0>Review the settings</0> for your IPFS node, and update them to better suit your needs.</0>",
Expand Down
2 changes: 1 addition & 1 deletion public/locales/sv/files.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"welcomeInfo": {
"header": "Välkommen till IPFS webb-gränssnitt",
"paragraph1": "<0><0>Check the status</0> of your node, it's Peer ID and connection info, the network traffic and the number of connected peers.</0>",
"paragraph2": "<0>Easily <1>manage files</1> in your IPFS repo. You can drag and drop to add files, move and rename them, delete, share or download them.</0>",
"paragraph2": "<0>Easily manage files in your IPFS repo. Drag and drop here to add files, move and rename them, delete, share or download them.</0>",
"paragraph3": "<0>You can <1>explore IPLD data</1> that underpins how IPFS works.</0>",
"paragraph4": "<0>See all of your <1>connected peers</1>, geolocated by their IP address.</0>",
"paragraph5": "<0><0>Review the settings</0> for your IPFS node, and update them to better suit your needs.</0>",
Expand Down
4 changes: 2 additions & 2 deletions src/files/info-boxes/welcome-info/WelcomeInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ const WelcomeInfo = ({ t }) => (
<Box>
<h1 className='mt0 mb3 montserrat fw4 f4 charcoal'>{t('welcomeInfo.header')}</h1>
<Trans i18nKey='welcomeInfo.paragraph1' t={t}>
<p className='f5'><a href='#/' className='link blue u b'>Check the status</a> of your node, it's Peer ID and connection info, the network traffic and the number of connected peers.</p>
<p className='f5'><a href='#/' className='link blue u b'>Check the status</a> of your node, its Peer ID and connection info, the network traffic and the number of connected peers.</p>
</Trans>
<Trans i18nKey='welcomeInfo.paragraph2' t={t}>
<p className='f5'>Easily <a href='#/files' className='link blue b'>manage files</a> in your IPFS repo. You can drag and drop to add files, move and rename them, delete, share or download them.</p>
<p className='f5'>Easily manage files in your IPFS repo. Drag and drop here to add files, move and rename them, delete, share or download them.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't need HTML manipulated translations, you can replace all of these with

<p className='f5'>{ t('welcomeInfo.paragraph2') }</p>

But if you want to keep consistency with the rest of the page, I don't mind 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it as is – can be refactored in separate PR.

</Trans>
<Trans i18nKey='welcomeInfo.paragraph3' t={t}>
<p className='f5'>You can <a href='#/explore' className='link blue b'>explore IPLD data</a> that underpins how IPFS works.</p>
Expand Down