This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: convert input to buffers before passing to aws-sdk #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aws-sdk uses the node http client internally which doesn't support Uint8Arrays as data, only [strings or buffers](https://nodejs.org/api/http.html#http_request_end_data_encoding_callback) so convert non-Buffers to Buffers before passing them on. Converts Buffers to Uint8Arrays via no-copy method to remain consistent with other interface-datastore implementations. Updates deps to use latest interface-datastore and aegir. BREAKING CHANGE: - Returns Uint8Arrays only where before it was node Buffers
|
The output conversion may be an overreach, can remove if so desired. |
jacobheun
force-pushed
the
fix/covert-to-buffers-before-passing-to-aws
branch
from
9d64304 to
0d1eab8
Compare
jacobheun
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
LGTM. @achingbrain the example was failing so I updated it to verify everything was working.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aws-sdk uses the node http client internally which doesn't support Uint8Arrays as data, only strings or buffers so convert non-Buffers to Buffers before passing them on.
Converts Buffers to Uint8Arrays via no-copy method to remain consistent with other interface-datastore implementations.
Updates deps to use latest interface-datastore and aegir.
BREAKING CHANGE: