Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native-fetch types are made up #109

Closed
achingbrain opened this issue Mar 15, 2021 · 0 comments · Fixed by #125
Closed

native-fetch types are made up #109

achingbrain opened this issue Mar 15, 2021 · 0 comments · Fixed by #125
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@achingbrain
Copy link
Member

achingbrain commented Mar 15, 2021 •
edited
Loading

[email protected] shipped with types support which basically just re-exports types from node-fetch - this module has it's own version of types for native-fetch and they do not align.

This module should not re-type native-fetch and should use the types it exposes.
@achingbrain achingbrain added the need/triage Needs initial labeling and prioritization label Mar 15, 2021
@jacobheun jacobheun added kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Mar 15, 2021
achingbrain added a commit that referenced this issue May 4, 2021
@achingbrain
chore: remove native-fetch retyping
f5328e9 
These types are incorrect and cause errors in other modules.

Fixes #109
@achingbrain achingbrain mentioned this issue May 4, 2021
Merged
achingbrain added a commit that referenced this issue May 4, 2021
@achingbrain
fix: remove retyping of modules with types (#125)
f6406c5 
The types are incorrect and cause errors with modules that check the types of their deps.

Types for `is-electron` can be removed once cheton/is-electron#7 is resolved.

Fixes #109

BREAKING CHANGE: `ResponseWithURL` type is not exported any more as it uses a private name and causes an inconsistency between node and the browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove retyping of modules with types ipfs/js-ipfs-utils
2 participants
@jacobheun @achingbrain