fix: remove retyping of modules with types #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They cause errors with powergate
vasco-santos
reviewed
May 2, 2021
These types are incorrect and cause errors in other modules. Fixes #109
iso-url and electron-fetch export their own types so do not retype them here. We can remove is-electron too once cheton/is-electron#7 is resolved.
achingbrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types are incorrect and cause errors with modules that check the types of their deps.
Types for
is-electroncan be removed once cheton/is-electron#7 is resolved.Fixes #109
BREAKING CHANGE:
ResponseWithURLtype is not exported any more as it uses a private name and causes an inconsistency between node and the browser