Fetch only takes a string, not a UrlWithLegacySupport

[roderik]

In https://github.com/ipfs/js-ipfs-utils/blob/master/src/http.js#L134-L159 the call to make is put into iso-url which returns a UrlWithLegacySupport.

A few lines lower, this is passed into fetch.

This throws the following error:

TypeError [ERR_INVALID_ARG_TYPE]: The "url" argument must be of type string. Received an instance of URLWithLegacySupport
    at validateString (internal/validators.js:124:11)
    at Url.parse (url.js:159:3)
    at urlParse (url.js:154:13)
    at new Request (/home/coder/project/node_modules/node-fetch/lib/request.js:27:16)
    at /home/coder/project/node_modules/node-fetch/index.js:51:17
    at new Promise (<anonymous>)
    at new Fetch (/home/coder/project/node_modules/node-fetch/index.js:49:9)
    at Fetch (/home/coder/project/node_modules/node-fetch/index.js:37:10)
    at Client.fetch (/home/coder/project/node_modules/ipfs-utils/src/http.js:148:36)
    at Client.fetch (/home/coder/project/node_modules/ipfs-http-client/src/lib/core.js:162:20)
    at Client.post (/home/coder/project/node_modules/ipfs-utils/src/http.js:190:17)
    at addAll (/home/coder/project/node_modules/ipfs-http-client/src/add-all.js:22:27)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at last (/home/coder/project/node_modules/it-last/index.js:15:20)
    at Object.add (/home/coder/project/node_modules/ipfs-http-client/src/add.js:18:14)

Changing the fetch call to the following fixes this, but I'm wondering how this code has been in use in this repo for a long time and suddenly it starts erroring out for me.

    const response = await timeout(fetch(url.href, {

I tried Node 12 and 14, no difference there. (I was hoping url.parse was changed)

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[roderik]

[email protected] works, 48.0.0 does not, so I suspect ipfs/js-ipfs#3351

[roderik]

Do I need to cross-post in the other repo, because it does not seem to be a utils issue?

[achingbrain]

I can't replicate this, and we have lots of tests that run with the HTTP client, but you are quite right, the fetch docs say the first argument should be a string and not a URL.

Could you create a PR to this module that just calls toString() on the url being passed to fetch? That should do it.

[roderik]

Done