Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

run-in-electron example not working #2011

Closed
guoliu opened this issue May 1, 2019 · 2 comments
Closed

run-in-electron example not working #2011

guoliu opened this issue May 1, 2019 · 2 comments
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@guoliu
Copy link

guoliu commented May 1, 2019

  • Version:
    js-ipfs version: 0.35.0-
    Repo version: 7
    System version: x64/darwin
    Node.js version: v11.10.1

  • Platform:
    macOS 10.14.3

Type: Bug

Severity: Low

Description:

run-in-electron example throws error:

App threw an error during load
/Users/liuguo/repos/js-ipfs/examples/run-in-electron/node_modules/pull-stream-to-async-iterator/index.js:4
  return (async function * () {
                         ^

SyntaxError: Unexpected token *
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:606:28)
    at Object.Module._extensions..js (module.js:653:10)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (module.js:586:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/liuguo/repos/js-ipfs/examples/run-in-electron/node_modules/async-iterator-to-pull-stream/index.js:2:20)

Looks like due to async-iterator-to-pull-stream not exporting transpiled ES5 code. See: alanshaw/pull-stream-to-async-iterator#1

How is this example intended to work originally, am I missing something?

Steps to reproduce the error:

Run npm start in examples/run-in-electron

@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue status/ready Ready to be worked labels May 3, 2019
This was referenced May 3, 2019
@hugomrdias
Copy link
Member

FYI im in the process of adding support for electron-main and electron-renderer to aegir

@ghost ghost removed the status/ready Ready to be worked label May 3, 2019
@guoliu
Copy link
Author

guoliu commented May 6, 2019

@hugomrdias thanks for the fast response!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants