Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue on node 11.10.0 #1

Closed
josselinchevalay opened this issue Feb 24, 2019 · 4 comments
Closed

issue on node 11.10.0 #1

josselinchevalay opened this issue Feb 24, 2019 · 4 comments

Comments

@josselinchevalay
Copy link

when i try to use this project : https://github.com/ipfs/js-ipfs/tree/master/examples/run-in-electron

i have this issue :

  return (async function * () {
                         ^

SyntaxError: Unexpected token *
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:606:28)
    at Object.Module._extensions..js (module.js:653:10)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (module.js:586:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/josselin/develop/migration-telescope/node_modules/async-iterator-to-pull-stream/index.js:2:20)
@lanmower
Copy link

lanmower commented Mar 4, 2019

me too :(
on node 8

@rmisio
Copy link

rmisio commented Mar 14, 2019

I think the problem is because the code on npm is not ES5 and most people running Babel are not transpiling node_modules code (nor probably should they).

@alanshaw Could you please publish transpiled ES5 code to npm?

@rmisio
Copy link

rmisio commented Mar 14, 2019

FWIW, when I upgraded my node version from 9.8 to 11.10.1, I don't get this issue.

But... I 'm not sure modern browsers natively support async generators, so it's probably safer for the repo maintainer to publish transpiled code.

josselinchevalay added a commit to josselinchevalay/pull-stream-to-async-iterator that referenced this issue Mar 23, 2019
@alanshaw
Copy link
Owner

alanshaw commented Feb 3, 2020

@alanshaw alanshaw closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants