Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Enable preload on MFS commands that accept IPFS paths #2335

Closed
alanshaw opened this issue Aug 6, 2019 · 1 comment · Fixed by #2355
Closed

Enable preload on MFS commands that accept IPFS paths #2335

alanshaw opened this issue Aug 6, 2019 · 1 comment · Fixed by #2355
Assignees
@alanshaw
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@alanshaw
Copy link
Member

alanshaw commented Aug 6, 2019

Some MFS commands accept IPFS paths as input. When IPFS paths are passed, we should send a preload request so that the content can be retrieved.

Notably, the CID resolver in ipfs-http-response switched to using ipfs.files.stat instead of ipfs.object.stat (ipfs/js-ipfs-http-response#19). This means that a JS IPFS gateway currently does not send preload requests and so is useful only for fetching content the node or the preload nodes already have in their repo.

cc @lidel @achingbrain @vasco-santos
@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up labels Aug 6, 2019
@lidel
Copy link
Member

lidel commented Aug 12, 2019 •
edited
Loading

(late reply, just got back from vacation)

I am +1 for this: was experimenting and thinking about adding an explicit preload call for paths requested via embedded gateway in Brave, but doing it at ipfs.files.stat is even better.

Are there any cons to doing this?

@lidel lidel mentioned this issue Aug 12, 2019
Closed
52 tasks
@alanshaw alanshaw self-assigned this Aug 14, 2019
alanshaw pushed a commit that referenced this issue Aug 14, 2019
fix: enable preload on MFS commands that accept IPFS paths
8fa7cb7 
fixes #2335

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@alanshaw alanshaw mentioned this issue Aug 14, 2019
Merged
1 task
alanshaw pushed a commit that referenced this issue Aug 23, 2019
fix: enable preload on MFS commands that accept IPFS paths (#2355)
0e0d1dd 
fixes #2335

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanshaw alanshaw

Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enable preload on MFS commands that accept IPFS paths ipfs/js-ipfs
2 participants
@alanshaw @lidel