This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ipfs.block.put is missing the pin argument #3015
Labels
need/triage
Needs initial labeling and prioritization
Comments
achingbrain
added a commit
that referenced
this issue
May 1, 2020
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
achingbrain
added a commit
that referenced
this issue
May 1, 2020
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
achingbrain
added a commit
that referenced
this issue
May 1, 2020
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
achingbrain
added a commit
that referenced
this issue
May 1, 2020
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
achingbrain
added a commit
that referenced
this issue
May 1, 2020
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
achingbrain
added a commit
that referenced
this issue
May 1, 2020
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
achingbrain
added a commit
that referenced
this issue
May 1, 2020
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
SgtPooki
referenced
this issue
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It should be added for parity with go-ipfs
The text was updated successfully, but these errors were encountered: