Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass ipfs config show errors #722

Merged
merged 4 commits into from
Oct 19, 2022
Merged

fix: pass ipfs config show errors #722

merged 4 commits into from
Oct 19, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Mar 14, 2022

Closes #721

@lidel lidel requested review from achingbrain and SgtPooki March 14, 2022 22:51
@lidel
Copy link
Member Author

lidel commented Mar 14, 2022 •
edited
Loading

@SgtPooki mind pushing this over the finish line? it needs some typescript definitions to pass CI

lidel added a commit to ipfs/ipfs-desktop that referenced this pull request Mar 14, 2022
@lidel
fix: pass ipfs config show error
3e4ce98 
Patching until ipfs/js-ipfsd-ctl#722 is released
@lidel lidel mentioned this pull request Mar 14, 2022
Merged
lidel added a commit to ipfs/ipfs-desktop that referenced this pull request Mar 14, 2022
@lidel
fix: pass ipfs config show error (#2032)
d63a689 
Patching until ipfs/js-ipfsd-ctl#722 is released
@SgtPooki SgtPooki self-assigned this Mar 15, 2022
@BigLep
Copy link

BigLep commented Mar 25, 2022

@SgtPooki : please also add auto-release

achingbrain
achingbrain requested changes May 25, 2022
View reviewed changes
src/ipfsd-daemon.js Outdated Show resolved Hide resolved
@BigLep BigLep assigned lidel and unassigned SgtPooki May 27, 2022
SgtPooki
SgtPooki requested changes Sep 12, 2022
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still needed? Idk how this slipped by me but I can take this tomorrow

@SgtPooki SgtPooki assigned SgtPooki and unassigned lidel Oct 5, 2022
@SgtPooki SgtPooki force-pushed the fix/pass-config-show-errors branch from ac1316f to aba229e Compare October 5, 2022 19:37
@SgtPooki SgtPooki merged commit efb2779 into master Oct 19, 2022
@SgtPooki SgtPooki deleted the fix/pass-config-show-errors branch October 19, 2022 01:08
@SgtPooki SgtPooki mentioned this pull request Oct 19, 2022
Closed
github-actions bot pushed a commit that referenced this pull request Oct 19, 2022
@semantic-release-bot
chore(release): 12.2.2 [skip ci]
2323bed 
## [12.2.2](v12.2.1...v12.2.2) (2022-10-19)

### Bug Fixes

* pass ipfs config show errors ([#722](#722)) ([efb2779](efb2779)), closes [#721](#721)
@github-actions
Copy link

🎉 This PR is included in version 12.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain requested changes

@SgtPooki SgtPooki SgtPooki requested changes

Assignees

@SgtPooki SgtPooki

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to trap JSON.parse and emit more informative error on parse failure
4 participants
@lidel @BigLep @achingbrain @SgtPooki