-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps!: update multiformats to version 11.x.x #123
Conversation
@achingbrain the builds broken because of the mismatch on releases that should have went out in js-ipfs, example:
The latest seems to be downloading a mismatched version. |
Looks like this is blocked on ipfs/js-ipfs#4252 then, this will update I think going forward this module should not have any deps on
|
js-ipfs has shipped so I've updated the deps here. It turns out I need this in to get the interop PR to pass. The only dep that still has [email protected] is I think this is good to go. One thing I noticed is this module uses custom eslint rules but uses aegir to actually do the linting. I would say please don't do this - either use aegir in it's entirety, with it's dependencies, defaults and presets or don't use it at all. Managing linting config and deps in other modules leads to inconsistencies, incompatibilities and all the sort of busywork that aegir is specifically intended to remove. Looking at the git history it looks like it may have been added to get over a hump rather than by design or preference so I've pulled it all out in 697a56f. Please let me know if you disagree. |
Also, this should probably go out as a major as the CID type returned from API methods will not have type overlap with the previous version after this is merged - it needs
If this is done, semantic-release will rev the version number and create the release notes accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the caveat that this needs to go out as a major - see #123 (comment)
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
NPM Update Plan for [email protected]
[Objective]: to make it compatible with [email protected]
Phase 1:
Phase 2:
Phase 3:
Phase 4: