Skip to content

Commit

Permalink
don't expose "version deps" on the gateway
Browse files Browse the repository at this point in the history
TMI

License: MIT
Signed-off-by: Steven Allen <[email protected]>
  • Loading branch information
Stebalien committed Apr 4, 2019
1 parent b50b8f4 commit 6c22bf8
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions core/commands/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ var CommandsDaemonROCmd = CommandsCmd(RootRO)
// RefsROCmd is `ipfs refs` command
var RefsROCmd = &cmds.Command{}

// VersionROCmd is `ipfs version` command (without deps).
var VersionROCmd = &cmds.Command{}

var rootROSubcommands = map[string]*cmds.Command{
"commands": CommandsDaemonROCmd,
"cat": CatCmd,
Expand Down Expand Up @@ -192,24 +195,27 @@ var rootROSubcommands = map[string]*cmds.Command{
},
},
"resolve": ResolveCmd,
"version": VersionCmd,
}

func init() {
Root.ProcessHelp()
*RootRO = *Root

// sanitize readonly refs command
*RefsROCmd = *RefsCmd
RefsROCmd.Subcommands = map[string]*cmds.Command{}

// this was in the big map definition above before,
// but if we leave it there lgc.NewCommand will be executed
// before the value is updated (:/sanitize readonly refs command/)

// sanitize readonly refs command
*RefsROCmd = *RefsCmd
RefsROCmd.Subcommands = map[string]*cmds.Command{}
rootROSubcommands["refs"] = RefsROCmd

Root.Subcommands = rootSubcommands
// sanitize readonly version command (no need to expose precise deps)
*VersionROCmd = *VersionCmd
VersionROCmd.Subcommands = map[string]*cmds.Command{}
rootROSubcommands["version"] = VersionROCmd

Root.Subcommands = rootSubcommands
RootRO.Subcommands = rootROSubcommands
}

Expand Down

0 comments on commit 6c22bf8

Please sign in to comment.