Skip to content

Commit

Permalink
CGO install note
Browse files Browse the repository at this point in the history
  • Loading branch information
@jbenet
jbenet committed Oct 14, 2014
1 parent 7366b7f commit d77f1f3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ cd $GOPATH/src/github.com/jbenet/go-ipfs/cmd/ipfs
go install
```

NOTE:
NOTES:

* `git` and mercurial (`hg`) are required in order for `go get` to fetch
all dependencies.
* Package managers often contain out-of-date `golang` packages.
Compilation from source is recommended.
* go-ipfs depends on cgo. In case you've disabled cgo, you'll need to
compile with `CGO_ENABLED=1`
* If you are interested in development, please install the development
dependencies as well.

Expand Down

5 comments on commit d77f1f3

@jbenet
Copy link
Member Author

@jbenet jbenet commented on d77f1f3 Oct 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cryptix how does this look?

@cryptix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@whyrusleeping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which dependencies are we using that require CGO? Might be nice to have them listed out (i personally dislike CGO stuff and would rather have pure go libraries as often as possible)

@cryptix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first problem I saw was the homedir/end lookup to find the config file. Didn't look further yet. Do we use the systems SSL certificate chain? Afaik that causes issues too if CGO is disabled.

@jbenet
Copy link
Member Author

@jbenet jbenet commented on d77f1f3 Oct 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, we don't use the CA system.

Please sign in to comment.