-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add in a default file hash and cleaned up init functiona bit
- Loading branch information
1 parent
60ef8e5
commit eaa68be
Showing
2 changed files
with
99 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaa68be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whyrusleeping
@mappum
@jbenet
#263 introduces the cli library that makes use of the new commands framework. While that PR is in progress, if we're not diligent, the two versions of the CLI will drift.
In may take a couple days to get the PR merged. During that time, we should probably no longer modify commands in the old package.
init
was updated in the new package yesterday, here:https://github.com/jbenet/go-ipfs/blob/cmd-ref-part2/cmd/ipfs2/init.go
eaa68be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must say...
I prefer your decomposition to mine.
eaa68be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
eaa68be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whyrusleeping I will take care of adding these adjustments to the new package