Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go1.6b1 #2108

Closed
cryptix opened this issue Dec 19, 2015 · 3 comments
Closed

go1.6b1 #2108

cryptix opened this issue Dec 19, 2015 · 3 comments

Comments

@cryptix
Copy link
Contributor

cryptix commented Dec 19, 2015

In Go 1.6b1 and later, you no longer need to use the GO15VENDOREXPERIMENT env var. On the flipside you now see this when compiling ipfs:

package github.com/ipfs/go-ipfs/repo/fsrepo
        imports github.com/ipfs/go-ipfs/vendor/QmQg1J6vikuXF9oDvm4wpdeAUvvkVEKW1EYDw9HhTMnP2b/go-log: must be imported as QmQg1J6vikuXF9oDvm4wpdeAUvvkVEKW1EYDw9HhTMnP2b/go-lo

See 9ac239d for a fixing commit.

@cryptix
Copy link
Contributor Author

cryptix commented Dec 19, 2015

Also:

➜  go-ipfs git:(go1.6b1) ✗ go test github.com/ipfs/go-ipfs/commands/http
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x30 pc=0x57c2fd]

goroutine 82 [running]:
net/http.(*response).CloseNotify(0xc820302780, 0x0)
    /home/cryptix/gotip/src/net/http/server.go:1543 +0x18d
github.com/ipfs/go-ipfs/commands/http.internalHandler.ServeHTTP.func2(0x8014f1968, 0xc820302780, 0x8014f1928, 0xc82026d940, 0xc820182d70)
    /home/cryptix/go/src/github.com/ipfs/go-ipfs/commands/http/handler.go:155 +0x39
created by github.com/ipfs/go-ipfs/commands/http.internalHandler.ServeHTTP
    /home/cryptix/go/src/github.com/ipfs/go-ipfs/commands/http/handler.go:159 +0x6c1
FAIL    github.com/ipfs/go-ipfs/commands/http   0.043s

@whyrusleeping
Copy link
Member

that CloseNotify panic looks like a boatload of fun...

@Kubuxu
Copy link
Member

Kubuxu commented May 31, 2016

This was resolved in #2315

@Kubuxu Kubuxu closed this as completed May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants