fix go1.6rc2 panic where closenotify was called from wrong goroutine #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity. This message was auto-generated by https://gitcop.com |
Previously, this was the result when running a test with go1.6rc2:
go test github.com/ipfs/go-ipfs/commands/http
panic: net/http: CloseNotify called after ServeHTTP finished
goroutine 19 [running]:
net/http.(*response).CloseNotify(0xc8202ca1a0, 0x0)
/home/r/go/src/net/http/server.go:1533 +0x9d
github.com/ipfs/go-ipfs/commands/http.internalHandler.ServeHTTP.func2(0x7f42c9d1d180, 0xc8202ca1a0, 0x7f42c9d66e90, 0xc8200f0380, 0xc8201d40d0)
/home/r/src/github.com/ipfs/go-ipfs/commands/http/handler.go:143 +0x39
created by github.com/ipfs/go-ipfs/commands/http.internalHandler.ServeHTTP
/home/r/src/github.com/ipfs/go-ipfs/commands/http/handler.go:147 +0x49d
FAIL github.com/ipfs/go-ipfs/commands/http 0.013s
I had also encountered this panic when trying to use the webui.
License: MIT
Signed-off-by: Robert Carlsen <[email protected]>
rwcarlsen
force-pushed
the
fix-closenotify-panic
branch
from
752ce80 to
ed23d99
Compare
|
This LGTM and I think I even encountered this myself when trying to run go-ipfs build with 1.6.2rc2 in Alpine Linux. |
|
@rwcarlsen Great catch! thank you! this looks correct to me, there might be one other place this happens in but I can fix it |
whyrusleeping
added a commit
that referenced
this pull request
Feb 8, 2016
fix go1.6rc2 panic where closenotify was called from wrong goroutine
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is referenced in the comments of #2108. Docker had a similar bug mentioned in golang/go#14001