Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands: don't panic when setting up options #311

Closed
btc opened this issue Nov 12, 2014 · 1 comment
Closed

commands: don't panic when setting up options #311

btc opened this issue Nov 12, 2014 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)
Milestone
merge-commands

Comments

@btc
Copy link
Contributor

btc commented Nov 12, 2014

I believe this can be addressed with a safer function signature. Will put into the queue of things to address.

reference: 173a041
@btc btc added the kind/bug A bug in existing code (including security flaws) label Nov 12, 2014
@btc btc self-assigned this Nov 12, 2014
@btc btc added this to the merge commands milestone Nov 12, 2014
@btc
Copy link
Contributor Author

btc commented Nov 12, 2014

low priority. will address last

@jbenet jbenet closed this as completed Nov 14, 2014
@btc btc removed their assignment Mar 30, 2015
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@Stebalien
dialQueue: start the control loop later
29d5b4a 
Don't start the control loop till we start the queue. The _in_ queue will still
work, we just won't start processing peers from it until we start the control loop.

fixes ipfs#311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
merge-commands
Development

No branches or pull requests
2 participants
@jbenet @btc