Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount async craziness cleanup #350

Closed
jbenet opened this issue Nov 16, 2014 · 1 comment · Fixed by #351
Closed

Mount async craziness cleanup #350

jbenet opened this issue Nov 16, 2014 · 1 comment · Fixed by #351
Assignees
@jbenet

Comments

@jbenet
Copy link
Member

jbenet commented Nov 16, 2014

No description provided.

@jbenet jbenet self-assigned this Nov 16, 2014
@mappum
Copy link
Contributor

mappum commented Nov 16, 2014

The reason I did that was because the mount functions block until an error happens. It might be an easy API change, I just didn't look into changing them.

jbenet added a commit that referenced this issue Nov 16, 2014
@jbenet
mount: fixed mount init + teardown
99f2378 
This commit adds a Mount abstraction (which is really just
a wrapped context closer). It makes sure to bind the mount
to the fate of the Node (i.e. close it if the node ends).
This fixes #350
@jbenet jbenet mentioned this issue Nov 16, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbenet jbenet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mount, Daemon, and Signal Handler Fixes ipfs/kubo
2 participants
@jbenet @mappum