Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DAGService/BlockService's Remove methods to take CIDs #4010

Closed
1 task
Stebalien opened this issue Jun 26, 2017 · 2 comments
Closed
1 task

Change DAGService/BlockService's Remove methods to take CIDs #4010

Stebalien opened this issue Jun 26, 2017 · 2 comments
Assignees
@Stebalien
Labels
help wanted Seeking public contribution on this issue
Milestone
Ipfs 0.4.12

Comments

@Stebalien
Copy link
Member

Stebalien commented Jun 26, 2017 •
edited
Loading

Currently, they take nodes/blocks but use CIDs internally. Taking a CID is more generally useful. Currently, to remove a node by CID, one has to first retrieve it :(.
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Jun 26, 2017
@Stebalien Stebalien self-assigned this Jun 26, 2017
Stebalien added a commit to Stebalien/go-ipld-format that referenced this issue Aug 17, 2017
@Stebalien
Make DAGService.Remove take a CID.
8a8e458 
We're going to want to do this eventually and we have to refactor anyways so we
might as well do this now.

Fixes ipfs/kubo#4010
@whyrusleeping whyrusleeping added this to the Ipfs 0.4.12 milestone Aug 31, 2017
@whyrusleeping
Copy link
Member

This can probably happen as part of the other cleanup work youre proposing

@Stebalien
Copy link
Member Author

Yes, that's my plan. I'll close this for now.

Stebalien added a commit to Stebalien/go-ipld-format that referenced this issue Oct 16, 2017
@Stebalien
Make DAGService.Remove take a CID.
2f52265 
We're going to want to do this eventually and we have to refactor anyways so we
might as well do this now.

Fixes ipfs/kubo#4010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
Ipfs 0.4.12
Development

No branches or pull requests
2 participants
@Stebalien @whyrusleeping