Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for deprecated IPNS records v1 #9240

Closed
lidel opened this issue Aug 31, 2022 · 0 comments · Fixed by #9265
Closed

Remove support for deprecated IPNS records v1 #9240

lidel opened this issue Aug 31, 2022 · 0 comments · Fixed by #9265
Assignees
@lidel
Labels
dif/medium effort/days Estimated to take multiple days, but less than a week kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up topic/ipns Topic ipns

Comments

@lidel
Copy link
Member

lidel commented Aug 31, 2022 •
edited
Loading

Part of ipfs/specs#314, corresponding JS-IPFS issue: ipfs/js-ipfs#4197

Support for extensible records (and v2 signature) was added in 2021. Kubo is producing and preferring updated v2 IPNS records by default, but if no v2 is found, it will still accept deprecated v1 for backward-compatibility during the transition period.

A year later, we should remove fallback support for validating v1 signatures and ignore them instead.
@lidel lidel added the kind/maintenance Work required to avoid breaking changes or harm to project's status quo label Aug 31, 2022
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Aug 31, 2022
@lidel lidel added topic/ipns Topic ipns P1 High: Likely tackled by core team if no one steps up effort/days Estimated to take multiple days, but less than a week dif/medium labels Aug 31, 2022
@lidel lidel mentioned this issue Aug 31, 2022
Closed
@lidel lidel self-assigned this Sep 6, 2022
@BigLep BigLep moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Sep 8, 2022
lidel added a commit to ipfs/go-ipns that referenced this issue Sep 12, 2022
@lidel
chore: require V2 signatures
b655f6b 
This is part of deprecation described in ipfs/kubo#9240
- record creation continues to create both V1 and V2  signatures
- record validation no longer accepts V1 signatures

Meaning:
- modern nodes are 100% V2, they ignore V1 signatures
- legacy nodes (go-ipfs < v0.9.0) are still able to resolve names
  created by go-ipns, because V1 is still present
This was referenced Sep 12, 2022
Merged
Merged
Repository owner moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Sep 20, 2022
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this issue Mar 23, 2023
@lidel
chore: require V2 signatures
f02f43c 
This is part of deprecation described in ipfs/kubo#9240
- record creation continues to create both V1 and V2  signatures
- record validation no longer accepts V1 signatures

Meaning:
- modern nodes are 100% V2, they ignore V1 signatures
- legacy nodes (go-ipfs < v0.9.0) are still able to resolve names
  created by go-ipns, because V1 is still present


This commit was moved from ipfs/go-ipns@b655f6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
dif/medium effort/days Estimated to take multiple days, but less than a week kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up topic/ipns Topic ipns
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: require IPNS V2 signatures ipfs/kubo
1 participant
@lidel