Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --empty-repo option for init (#1559) #1592

Merged
merged 2 commits into from
Aug 28, 2015
Merged

Add --empty-repo option for init (#1559) #1592

merged 2 commits into from
Aug 28, 2015

Conversation

prusnak
Copy link
Contributor

@prusnak prusnak commented Aug 19, 2015

No description provided.

@jbenet jbenet added the backlog label Aug 19, 2015
@GitCop
Copy link

GitCop commented Aug 19, 2015

There were the following issues with your Pull Request

  • Commit: efa7231
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

License: MIT
Signed-off-by: Pavol Rusnak <[email protected]>
@prusnak
Copy link
Contributor Author

prusnak commented Aug 20, 2015

Seems that one Travis test exited with a weird error, most probably unrelated to the pull request:

https://travis-ci.org/ipfs/go-ipfs/jobs/76375495

The other three seem fine.

@jbenet
Copy link
Member

jbenet commented Aug 21, 2015

@prusnak LGTM. i think needs a test to make sure we dont add regressions. (see the sharness tests. just make a new file, probably based on the repo one, or init or daemon. and test the initial state after initing with the option.

License: MIT
Signed-off-by: Christian Couder <[email protected]>
@chriscool
Copy link
Contributor

Here is a test I wrote for this:

chriscool@872daf8

@chriscool
Copy link
Contributor

@prusnak and @jbenet what do you want to do on this?
@prusnak feel free to cherry pick the commit that contains the test and push it into this branch.
Otherwise I can also create a PR from the empty-repo branch on my fork (https://github.com/chriscool/go-ipfs/commits/empty-repo).

@jbenet
Copy link
Member

jbenet commented Aug 28, 2015

the PR LGTM. +1 to having tests before merging it. whoever does it first, wins a ⭐

@prusnak
Copy link
Contributor Author

prusnak commented Aug 28, 2015

Pulled chriscool/empty-repo into this PR.

@jbenet
Copy link
Member

jbenet commented Aug 28, 2015

ok thanks @prusnak

jbenet added a commit that referenced this pull request Aug 28, 2015
Add --empty-repo option for init (#1559)
@jbenet jbenet merged commit 9f253df into ipfs:master Aug 28, 2015
@jbenet jbenet removed the backlog label Aug 28, 2015
@prusnak prusnak deleted the empty-repo branch August 28, 2015 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants