Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to the latest version of the webui #2188

Merged
merged 1 commit into from
Jan 12, 2016

Conversation

dignifiedquire
Copy link
Member

Ref #2162

@GitCop
Copy link

GitCop commented Jan 12, 2016

There were the following issues with your Pull Request

  • Commit: da7b22f
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

License: MIT
Signed-off-by: Friedel Ziegelmayer <[email protected]>
@RichardLitt
Copy link
Member

That's weird, that sign off looks fine to me.

@dignifiedquire
Copy link
Member Author

@RichardLitt force push ;)

@whyrusleeping
Copy link
Member

LGTM

whyrusleeping added a commit that referenced this pull request Jan 12, 2016
feat: Update to the latest version of the webui
@whyrusleeping whyrusleeping merged commit 7070b4d into ipfs:master Jan 12, 2016
@dignifiedquire dignifiedquire deleted the feat/webui-update branch January 12, 2016 16:11
@jbenet
Copy link
Member

jbenet commented Jan 12, 2016

@whyrusleeping did you test it manually before merging?

@whyrusleeping
Copy link
Member

Yeap! on two machines

@whyrusleeping
Copy link
Member

(and on firefox)

@whyrusleeping
Copy link
Member

and we ran through all the tests for js-ipfs-api

@jbenet
Copy link
Member

jbenet commented Jan 12, 2016

👍

hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
feat: Update to the latest version of the webui

This commit was moved from ipfs/kubo@7070b4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants