Add option to decode 'Data' field as base64 #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity. This message was auto-generated by https://gitcop.com |
License: MIT Signed-off-by: [email protected] <[email protected]>
| @@ -342,6 +344,7 @@ And then run: | |||
| }, | |||
| Options: []cmds.Option{ | |||
| cmds.StringOption("inputenc", "Encoding type of input data, either \"protobuf\" or \"json\"."), | |||
| cmds.StringOption("datafieldenc", "Encoding type of the data field, either \"text\" or \"base64\"."), | |||
There was a problem hiding this comment.
add .Default("text") to the end of this option, so you don't have to do the !found check later
added 2 commits
April 4, 2016 13:09
License: MIT Signed-off-by: slothbag <[email protected]>
License: MIT Signed-off-by: slothbag <[email protected]>
|
cool, lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first crack at go code.. so feel free to criticize and make suggestions.
My goal here is to retain the current
ipfs object putlogic, but allow a --datafieldenc argument which accepts "text" ot "base64". Default is "text" to retain previous functionality. Then I can upload raw binary data using--datafieldenc base64and a base64 encoded data field.Reference Issue #1582