Add multiplex tests to t0130. #3556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
I figure this is more of a bug report than to-be-merged eh? The tests LGTM though :) |
|
@whyrusleeping asked me to write this test and it turns out it is failing. |
|
CHANGELOG: |
|
I added it to initial PR comment, do you think it is better idea. |
| @@ -87,6 +87,13 @@ test_expect_success "set up tcp testbed" ' | |||
| iptb init -n 5 -p 0 -f --bootstrap=none | |||
| ' | |||
|
|
|||
| # test multiplex muxer | |||
| export LIBP2P_MUX_PREFS="/mplex/6.7.0 /yamux/1.0.0 /spdy/3.1.0" | |||
There was a problem hiding this comment.
just to be a bit more certain of what we're testing, lets remove yamux and spdy from this list.
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
merged in #3582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reasons multiplex won't transfer those files, it hangs.
CHANGELOG:
test go-multiplex stream muxer in multinode sharness test.