Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filestore rm #3815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

filestore rm #3815

wants to merge 1 commit into from

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Mar 23, 2017

Factored out of #3653

@kevina kevina added the status/in-progress In progress label Mar 23, 2017
@kevina kevina changed the base branch from kevina/filestore-util to master March 23, 2017 06:46
@kevina kevina force-pushed the kevina/filestore-rm branch 2 times, most recently from ab1d575 to 72aed97 Compare March 23, 2017 20:25
@whyrusleeping whyrusleeping requested a review from Kubuxu March 30, 2017 18:06
@whyrusleeping
Copy link
Member

Would the recommended way of deduping between filestore and blockstore be ipfs filestore dups | ipfs filestore rm ?

@kevina
Copy link
Contributor Author

kevina commented Jun 1, 2017 •
edited
Loading

Would the recommended way of deduping between filestore and blockstore be ipfs filestore dups | ipfs filestore rm ?

More or less.

@kevina kevina mentioned this pull request Sep 2, 2017
Open
@kevina kevina mentioned this pull request Sep 21, 2017
Open
Kubuxu
Kubuxu reviewed Oct 9, 2017
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGWM

filestore/remove.go Outdated
case bs.BlockPrefix.String():
blocks = fs.bs
default:
return nil, fmt.Errorf("Unknown prefix: %s\n", opts.Prefix)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors should start with lower case.

This was referenced Oct 11, 2017
Merged
Closed
@kevina kevina force-pushed the kevina/filestore-rm branch 5 times, most recently from d0cc4ea to e125ded Compare October 13, 2017 03:13
@ghost ghost assigned kevina Oct 13, 2017
@kevina kevina changed the base branch from master to feat/commands2.0 October 13, 2017 03:13
@keks keks force-pushed the feat/commands2.0 branch from f96e6ce to 0cea75b Compare October 16, 2017 10:55
@keks keks force-pushed the feat/commands2.0 branch 4 times, most recently from 5cedf7c to 6ac1c1e Compare October 28, 2017 07:52
@keks keks force-pushed the feat/commands2.0 branch from 6ac1c1e to 7d2039a Compare November 2, 2017 15:04
@keks keks force-pushed the feat/commands2.0 branch 2 times, most recently from 434ee5c to d95a87c Compare November 17, 2017 14:23
@kevina kevina changed the base branch from feat/commands2.0 to master November 28, 2017 18:39
@kevina
filestore util: Add 'filestore rm' command.
32e09a6 
License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
@kevina kevina force-pushed the kevina/filestore-rm branch from e125ded to 32e09a6 Compare November 28, 2017 18:59
@radfish
Copy link

radfish commented Jan 15, 2018 •
edited
Loading

Would the recommended way of deduping between filestore and blockstore be ipfs filestore dups | ipfs filestore rm ?

Would ipfs filestore dups | ipfs block rm also work (to keep in the filestore, but delete from blockstore)?
EDIT: nevermind, i read the patch: ipfs filestore rm --non-filestore.

@kevina
Copy link
Contributor Author

kevina commented Jan 15, 2018

Would ipfs filestore dups | ipfs block rm also work (to keep in the filestore, but delete from blockstore)?

@radfish no that will remove it from both the blockstore and filestore. With this p.r. to remove from the filestore use ipfs filestore rm to remove just the blockstore use ipfs filestore rm --non-filestore.

I am not against adding a --just-blockstore or similar option to ipfs block rm as that seams more intuitive for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevina @whyrusleeping @radfish @Kubuxu