Code

Bitswap Rounds CR suggestions #2#459

Code

Merged

whyrusleeping merged 41 commits intobitswap-roundsipfs/kubo:bitswap-roundsfrom bitswap-rounds-CR-by-btcipfs/kubo:bitswap-rounds-CR-by-btcCopy head branch name to clipboardDec 17, 2014

+525-453

Commits

Commits on Dec 17, 2014

• fix(test): nil Blockstore

  Show description for 7281f66
  

  Brian Tiger Chow

  committed
  7281f66

  Copy full SHA for 7281f66

• style: line wrapping

  Show description for 260629e
  

  Brian Tiger Chow

  committed
  260629e

  Copy full SHA for 260629e

• fix: move to callsite so public callers don't experience the internal timeout rule

  Show description for 32ae1f9
  

  Brian Tiger Chow

  committed
  32ae1f9

  Copy full SHA for 32ae1f9

• style constify variables

  Show description for b188a2c
  

  Brian Tiger Chow

  committed
  b188a2c

  Copy full SHA for b188a2c

• refactor: change Tasks to Outbox

  Show description for 0056361
  

  Brian Tiger Chow

  committed
  0056361

  Copy full SHA for 0056361

• refactor: avoid loop reuse

  Show description for bb92988
  

  Brian Tiger Chow

  committed
  bb92988

  Copy full SHA for bb92988

• fix: move the check into the function.

  Show description for 4e1818d
  

  Brian Tiger Chow

  committed
  4e1818d

  Copy full SHA for 4e1818d

• refactor: context first in argument list

  Show description for 0d77e02
  

  Brian Tiger Chow

  committed
  0d77e02

  Copy full SHA for 0d77e02

• doc: comment

  Show description for be87976
  

  Brian Tiger Chow

  committed
  be87976

  Copy full SHA for be87976

• refactor: taskKey := p.Key() + block.Key()

  Show description for fda0617
  

  Brian Tiger Chow

  committed
  fda0617

  Copy full SHA for fda0617

• unexport task and taskList

  Show description for 68ae09f
  

  Brian Tiger Chow

  committed
  68ae09f

  Copy full SHA for 68ae09f

• refactor: remove peerKey type

  Show description for 9d2c54c
  

  Brian Tiger Chow

  committed
  9d2c54c

  Copy full SHA for 9d2c54c

• add comment to fix race

  Show description for 9259f66
  

  Brian Tiger Chow

  committed
  9259f66

  Copy full SHA for 9259f66

• perf: avoid lots of communication by signaling once at end of method

  Show description for 3d1d19c
  

  Brian Tiger Chow

  committed
  3d1d19c

  Copy full SHA for 3d1d19c

• it's not a queue yet but it's okay to name it as such

  Show description for f7310a4
  

  Brian Tiger Chow

  committed
  f7310a4

  Copy full SHA for f7310a4

• tq.Cancel -> tq.Remove

  Show description for 9a6bb16
  

  Brian Tiger Chow

  committed
  9a6bb16

  Copy full SHA for 9a6bb16

• privatize Task

  Show description for 72584ec
  

  Brian Tiger Chow

  committed
  72584ec

  Copy full SHA for 72584ec

• doc: add comment to Envelope

  Show description for 09ab411
  

  Brian Tiger Chow

  committed
  09ab411

  Copy full SHA for 09ab411

• refactor: re-use wantlist.Entry type wherever it makes sense

  Show description for 39ee5eb
  

  Brian Tiger Chow

  committed
  39ee5eb

  Copy full SHA for 39ee5eb

• refactor: separate responsibilties

  Show description for 37b1f50
  

  Brian Tiger Chow

  committed
  37b1f50

  Copy full SHA for 37b1f50

• mv comment

  Show description for b23869f
  

  Brian Tiger Chow

  committed
  b23869f

  Copy full SHA for b23869f

• refactor: remove ledgerMap type

  Show description for b0a2ee6
  

  Brian Tiger Chow

  committed
  b0a2ee6

  Copy full SHA for b0a2ee6

• refactor: put mutex next to the things it protects

  Show description for 87e94f9
  

  Brian Tiger Chow

  committed
  87e94f9

  Copy full SHA for 87e94f9

• refactor: wantlist splits into WL and ThreadSafe WL

  Show description for 81c0979
  

  Brian Tiger Chow

  committed
  81c0979

  Copy full SHA for 81c0979

• rename to strategy.LedgerManager to decision.Engine

  Show description for aac777d
  

  Brian Tiger Chow

  committed
  aac777d

  Copy full SHA for aac777d

• rm empty file

  Show description for 1a2e9ee
  

  Brian Tiger Chow

  committed
  1a2e9ee

  Copy full SHA for 1a2e9ee

• rename to peerRequestQueue

  Show description for d5bb556
  

  Brian Tiger Chow

  committed
  d5bb556

  Copy full SHA for d5bb556

• fix: don't sort the output of Entries()

  Show description for 666ac0b
  

  Brian Tiger Chow

  committed
  666ac0b

  Copy full SHA for 666ac0b

• rm unused method

  Show description for 72965e6
  

  Brian Tiger Chow

  committed
  72965e6

  Copy full SHA for 72965e6

• add comment

  Show description for 167fbac
  

  Brian Tiger Chow

  committed
  167fbac

  Copy full SHA for 167fbac

• unexport functions

  Show description for 7b93d74
  

  Brian Tiger Chow

  committed
  7b93d74

  Copy full SHA for 7b93d74

• fix: check blockstore before adding task

  Show description for f5133db
  

  Brian Tiger Chow

  committed
  f5133db

  Copy full SHA for f5133db

• log unusual event

  Show description for 61ab0df
  

  Brian Tiger Chow

  committed
  61ab0df

  Copy full SHA for 61ab0df

• fix: set peerset size

  Show description for 6edef72
  

  Brian Tiger Chow

  committed
  6edef72

  Copy full SHA for 6edef72

• doc: peerset fixme

  Show description for 76889a8
  

  Brian Tiger Chow

  committed
  76889a8

  Copy full SHA for 76889a8

• refactor: *Entry -> Entry

  Show description for 2c834af
  

  Brian Tiger Chow

  committed
  2c834af

  Copy full SHA for 2c834af

• extract constants

  Show description for fd1da4c
  

  Brian Tiger Chow

  committed
  fd1da4c

  Copy full SHA for fd1da4c

• refactor(bs/decision.Engine): pass in Entry

  Show description for 07c6a8b
  

  Brian Tiger Chow

  committed
  07c6a8b

  Copy full SHA for 07c6a8b

• fix: add lock to taskQueue

  Show description for d36c480
  

  Brian Tiger Chow

  committed
  d36c480

  Copy full SHA for d36c480

• doc: some comments about the future of the decision engine

  Show description for fa6e63c
  

  Brian Tiger Chow

  committed
  fa6e63c

  Copy full SHA for fa6e63c

• fix: batches of blocks have equal priority

  Show description for aaa46cc
  

  Brian Tiger Chow

  committed
  aaa46cc

  Copy full SHA for aaa46cc