remove Godeps #5440
remove Godeps #5440
Conversation
ghost
assigned 
Stebalien
force-pushed
the
feat/ungodep
branch
3 times, most recently
from
5bd1033 to
0c43c2c
Compare
Stebalien
force-pushed
the
feat/ungodep
branch
6 times, most recently
from
65eeda0 to
8aeaaa5
Compare
fixes #2722 License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
feat/ungodep
branch
from
8aeaaa5 to
0252710
Compare
test/3nodetest/Makefile
Outdated
| @@ -20,7 +19,8 @@ data/filerand: bin/random | |||
| ./bin/random 50000000 > ./data/filerand | |||
|
|
|||
| bin/random: $(RANDOMSRC)/**/*.go | |||
| go build -o ./bin/random $(RANDOMSRC)/random | |||
| go get github.com/jbenet/go-random | |||
| go build -o ./bin/random github.com/jbenet/go-random/random | |||
There was a problem hiding this comment.
This is the only real change. It uses go-get, not gx, but, as far as I can tell, we don't use these tests at the moment anyways.
There was a problem hiding this comment.
Isn't this also https://github.com/ipfs/go-ipfs/pull/5440/files#diff-c8660427d0699f8fe97cb9943c5bd91eR40? I'd just depend on that
test/3nodetest/Makefile
Outdated
| @@ -20,7 +19,8 @@ data/filerand: bin/random | |||
| ./bin/random 50000000 > ./data/filerand | |||
|
|
|||
| bin/random: $(RANDOMSRC)/**/*.go | |||
| go build -o ./bin/random $(RANDOMSRC)/random | |||
| go get github.com/jbenet/go-random | |||
| go build -o ./bin/random github.com/jbenet/go-random/random | |||
There was a problem hiding this comment.
Isn't this also https://github.com/ipfs/go-ipfs/pull/5440/files#diff-c8660427d0699f8fe97cb9943c5bd91eR40? I'd just depend on that
License: MIT Signed-off-by: Steven Allen <[email protected]>
SGTM. I was stuck trying to figure out the right gx hash (the makefile is independent of our make system) but I realized I can just use the other make system. LGTY? |
fixes #2722