Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update go-libp2p to v0.19.3 #8990

Merged
merged 1 commit into from
Jun 1, 2022
Merged

chore: update go-libp2p to v0.19.3 #8990

merged 1 commit into from
Jun 1, 2022

Conversation

marten-seemann
Copy link
Member

No description provided.

@marten-seemann marten-seemann requested a review from guseggert May 23, 2022 16:57
@marten-seemann
Copy link
Member Author

@BigLep There's nothing to do here for me, this just needs to be merged. Unassigning myself.

@marten-seemann marten-seemann removed their assignment May 24, 2022
@ajnavarro ajnavarro mentioned this pull request May 25, 2022
Closed
@ajnavarro
Copy link
Member

Thanks to @galargh indications, I executed Testground on master and it appears that this PR is causing slowness in Testground execution.
We should test updating the timeout (https://github.com/ipfs/go-ipfs/blob/master/.github/workflows/testground-on-push.yml#L33) to see if tests pass. If that is the case, I would suggest some investigation into what might be causing that slowness.

@ajnavarro
Copy link
Member

@guseggert shall we merge this for the new release? Thanks!

@guseggert
Copy link
Contributor

@marten-seemann Do you expect the changes to cause the tests to take longer and timeout? If not, do you still recommend we merge this?

@marten-seemann
Copy link
Member Author

The only change is how the Path MTU timer is handled in quic-go. This shouldn't have any effect on tests.

@guseggert guseggert merged commit f720172 into master Jun 1, 2022
@guseggert guseggert deleted the update-libp2p branch June 1, 2022 15:08
guseggert pushed a commit that referenced this pull request Jun 8, 2022
@marten-seemann @guseggert
chore: update go-libp2p to v0.19.3 (#8990)
b8a84e6
guseggert pushed a commit that referenced this pull request Jun 8, 2022
@marten-seemann @guseggert
chore: update go-libp2p to v0.19.3 (#8990)
9a77cc3 
(cherry picked from commit f720172)
guseggert pushed a commit that referenced this pull request Jun 8, 2022
@marten-seemann @guseggert
chore: update go-libp2p to v0.19.3 (#8990)
8dffa84 
(cherry picked from commit f720172)
guseggert pushed a commit that referenced this pull request Jun 8, 2022
@marten-seemann @guseggert
chore: update go-libp2p to v0.19.3 (#8990)
b58e6fd 
(cherry picked from commit f720172)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guseggert guseggert Awaiting requested review from guseggert

Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marten-seemann @ajnavarro @guseggert