add carv2.WrapV1 based on io interfaces #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires index.Generate to work on io.ReadSeeker, which is a good idea anyway, as it just needs to read and seek. The main advantage of ReaderAt is that it allows concurrent reads, but index generation is sequential by nature. Plus, it only needs seeking to skip blocks; it doesn't need random access to the carv1. Fixes #129.
|
FYI @raulk @willscott I ended up not touching any of the APIs taking io.ReaderAt, except for index.Generate. Its implementation gets a bit easier, and allows for WrapV1 to exist without hackery (such as implementing an io.ReaderAt on top of a io.ReadSeeker...). |
|
Also FYI @masih this removes a couple of uses of OffsetReader, which I think is a good thing - the fewer io layers we have, the better. |
|
Also, the change of API in index.Generate just works with the rest of the codebase, because CarV1Reader already implements ReadSeeker, too :) |
mvdan
pushed a commit
that referenced
this pull request
Jul 5, 2021
Accommodate to the `index.Generate` signature change, done in #136. Insead of implementng a new reader that converts `io.ReaderAt` to `io.ReadSeaker`, make `internalio.OffsetReader` partially implement `Seek`. The "partial" refers to inability to satisfy `Seek` calls with `io.SeekEnd` whence since the point of `internalio.OffsetReader` is that it needs not to know the total size of a file, i.e. cannot know its end. Instead, it panics if `Seek` is called with whence `io.SeekEnd`. None of this matterns much since it is all placed under internal APIs.
mvdan
pushed a commit
that referenced
this pull request
Jul 16, 2021
Accommodate to the `index.Generate` signature change, done in #136. Insead of implementng a new reader that converts `io.ReaderAt` to `io.ReadSeaker`, make `internalio.OffsetReader` partially implement `Seek`. The "partial" refers to inability to satisfy `Seek` calls with `io.SeekEnd` whence since the point of `internalio.OffsetReader` is that it needs not to know the total size of a file, i.e. cannot know its end. Instead, it panics if `Seek` is called with whence `io.SeekEnd`. None of this matterns much since it is all placed under internal APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)